fix(modal-checkout): ensure customer location when state is required but country is not #1683
Conversation
…but country is not
There was a problem hiding this comment.
Nice! This works for me @dkoo
Just one issue then this is good to go 👍
includes/class-modal-checkout.php
Outdated
| } | ||
|
|
||
| // If billing state is required but billing country is not, we need to ensure a default location is set. | ||
| $billing_fields = get_option( Donations::DONATION_BILLING_FIELDS_OPTION, [] ); |
There was a problem hiding this comment.
Donations::DONATION_BILLING_FIELDS_OPTION lives in the main plugin so we will need to do a check to confirm this is active here, then properly namespace it.
There was a problem hiding this comment.
Whoops, a victim of copy/paste syndrome! Fixed in 9c92297
|
🎉 This PR is included in version 3.0.4-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [3.0.5-alpha.1](v3.0.4...v3.0.5-alpha.1) (2024-03-07) ### Bug Fixes * **author-profile:** only display guest author profile when linked ([#1688](#1688)) ([ee1bb21](ee1bb21)) * correct carousel button styles in editor ([#1680](#1680)) ([d4aba73](d4aba73)) * **modal-checkout:** ensure customer location when state is required but country is not ([#1683](#1683)) ([27badf8](27badf8))
|
🎉 This PR is included in version 3.0.5-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [3.0.5](v3.0.4...v3.0.5) (2024-03-25) ### Bug Fixes * **author-profile:** only display guest author profile when linked ([#1688](#1688)) ([ee1bb21](ee1bb21)) * correct carousel button styles in editor ([#1680](#1680)) ([d4aba73](d4aba73)) * **modal-checkout:** ensure customer location when state is required but country is not ([#1683](#1683)) ([27badf8](27badf8))
|
🎉 This PR is included in version 3.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0-epic-ras-acc.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Alternative version of Automattic/newspack-plugin#2960, but isolated only to modal checkout instances.
How to test the changes in this Pull Request:
Follow testing instructions ins Automattic/newspack-plugin#2960
Other information: