Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render homepage posts blocks in feeds #562

Merged
merged 1 commit into from Aug 11, 2020

Conversation

philipjohn
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Sometimes it makes sense to include a homepage posts block in a post, for example to show a more targeted related post element. This can cause issues with RSS feeds through as the markup for a homepage posts block can confuse parsers and services that ingest feeds for syndication purposes.

The re-circulation benefits of the block being in a post aren't going to carry through to a feed and the styling will not be present so it's best to remove them from the feed entirely, as this change does.

How to test the changes in this Pull Request:

  1. Add a new post with a homepage posts block in the content
  2. View the main RSS feed and observe the block markup is added
  3. Apply the patch
  4. Reload the RSS feed and observe the markup is gone

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@philipjohn philipjohn merged commit e0a5a83 into master Aug 11, 2020
@philipjohn philipjohn deleted the fix/homepage-posts-in-feeds branch August 11, 2020 13:59
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants