fixed memory leaks in context2d #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would that happen to be this leak that Instruments is reporting? The code created a 500x500px canvas, getting its context and calling fillText() - that's all. Sucker leaks. |
Closed
|
Yes, the leak in your screenshot is due the initial state (alloc'd in the constructor) not beeing freed. |
|
Patching the code with your fix and rebuilding canvas (seems to) work like a champ. That leak is gone. |
|
Very weird I'm 99% sure we had this same patch 4 or 5 months ago! merging |
|
released 0.8.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found and fixed some memory leaks in the context2d implementation
1: The initial state and all states that were not popped by restore were not free'd
2: The path that is copied in savePath is not deleted after being appended back to the context in restorePath