Fixes an issue related to a wrong variable type (#182) #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was generated by passing the negative value of an unsigned variable as parameter of the function
AdjustAmountOfExternalAllocatedMemory
.The version of V8 included in node v0.8.x changed the param type of the function
AdjustAmountOfExternalAllocatedMemory
fromint
tointptr_t
.The result of this change is that if
foo
is an unsigned variable, passing-foo
toAdjustAmountOfExternalAllocatedMemory
is the same of passing the value(UINT_MAX - foo + 1)
and not the expected- foo
.Changing the type of the passed variable to
int16_t
fixed the issue.