Better streams that support being returned asynchronously. #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of this is done in #740... |
|
Yes, sorry, didn't see it. Feel free to close :) |
|
The test cases are good and I think those should be added at least! :) -- and it's a cool way to dedupe the core stream logic (although it exposes more private members)... |
|
Would be nice to land the test cases and possibly the deduped core stream logic :) would you mind rebasing? |
|
Sure, looking into it now. |
Streams refactoring.
AaronAsAChimp
force-pushed
the
better-streams
branch
from
1000699
to
c384952
Compare
|
Going to close for now since equivalent code changes are in. If you want to rebase sometime, happy to incorporate the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update createPNGStream and createJPEGStream to the new Streams API in Node >= 0.10. This will allow the streams to be returned asynchronously (e.g. Promises). Currently, the streams will read out all of the data before the promise is resolved.