Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase limit on playback speed to 5.0 #1645

Merged
merged 16 commits into from
Jun 7, 2024
Merged

Increase limit on playback speed to 5.0 #1645

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1653671
Increase limit on playback speed to 5.0
zimmerrol Dec 23, 2023
ecae010
Increase limit on playback speed to 5.0
zimmerrol Dec 23, 2023
dc22dfb
Merge upstream
zimmerrol Feb 23, 2024
af253ba
Merge upstream
zimmerrol Feb 23, 2024
1a7f564
Merge branch 'main' into feature/playback-speed
zimmerrol Mar 15, 2024
0c25834
Increase possible playback speed shown in notifications
zimmerrol Mar 15, 2024
751859f
Add missing notification drawables
zimmerrol May 30, 2024
7fdd01e
Change playback speed settings in notifications
zimmerrol May 30, 2024
6e3fc90
Update how playback speed is changed when clicking on the text
zimmerrol May 30, 2024
79aa2b8
Update range pattern
zimmerrol Jun 7, 2024
7bcca2f
Run file size optimization with optipng on all PNGs
zimmerrol Jun 7, 2024
bb40e8c
Revert "Run file size optimization with optipng on all PNGs"
zimmerrol Jun 7, 2024
91f543b
Run file size optimization with optipng on PNGs
zimmerrol Jun 7, 2024
d00611d
Merge remote-tracking branch 'upstream/main' into feature/playback-speed
zimmerrol Jun 7, 2024
33f1525
Include change in changelog
zimmerrol Jun 7, 2024
d65443c
Update unit test to new range
zimmerrol Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...atures/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/EffectsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class EffectsFragment : BaseDialogFragment(), CompoundButton.OnCheckedChangeList
val binding = binding ?: return

// val speed = (amount.clipToRange(0.5, 3.0) * 10.0).toInt() / 10.0
val speed = round(amount.clipToRange(0.5, 3.0) * 10.0) / 10.0
val speed = round(amount.clipToRange(0.5, 5.0) * 10.0) / 10.0
effects.playbackSpeed = speed
updatedSpeed = speed
binding.playbackSpeedString = String.format("%.1fx", effects.playbackSpeed)
Expand Down
2 changes: 1 addition & 1 deletion ...rc/main/java/au/com/shiftyjelly/pocketcasts/podcasts/viewmodel/PodcastEffectsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class PodcastEffectsViewModel

private fun changePlaybackSpeed(speed: Double) {
val podcast = this.podcast.value ?: return
val clippedToRangeSpeed = speed.clipToRange(0.5, 3.0)
val clippedToRangeSpeed = speed.clipToRange(0.5, 5.0)
// to stop the issue 1.2000000000000002
val roundedSpeed = round(clippedToRangeSpeed * 10.0) / 10.0
podcastManager.updatePlaybackSpeed(podcast, roundedSpeed)
Expand Down
2 changes: 1 addition & 1 deletion ...tyjelly/pocketcasts/taskerplugin/controlplayback/config/ViewModelConfigControlPlayback.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ViewModelConfigControlPlayback @Inject constructor(
InputField(LR.string.time_to_skip_to_seconds, IR.drawable.filter_time, InputControlPlayback.PlaybackCommand.SkipToTime, { skipToSeconds }, { skipToSeconds = it }),
InputField(LR.string.time_to_skip_seconds, IR.drawable.filter_time, listOf(InputControlPlayback.PlaybackCommand.SkipForward, InputControlPlayback.PlaybackCommand.SkipBack), { skipSeconds }, { skipSeconds = it }),
object : InputField<Double>(LR.string.playback_speed_between_values, R.drawable.speedometer, InputControlPlayback.PlaybackCommand.SetPlaybackSpeed, { playbackSpeed }, { playbackSpeed = it }) {
override fun getPossibleValues() = MutableStateFlow((5..30).map { it / 10.0 })
override fun getPossibleValues() = MutableStateFlow((5..50).map { it / 10.0 })
},
object : InputField<TrimMode>(LR.string.trim_silence_mode, R.drawable.content_cut, InputControlPlayback.PlaybackCommand.SetTrimSilenceMode, { trimSilenceMode }, { trimSilenceMode = it }) {
override fun getPossibleValues() = MutableStateFlow(TrimMode.values().toList())
Expand Down
2 changes: 1 addition & 1 deletion wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/player/EffectsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class EffectsViewModel
private fun changePlaybackSpeed(speed: Double) {
val currentState = state.value as? State.Loaded ?: return
val effects = currentState.playbackEffects
val clippedToRangeSpeed = speed.clipToRange(0.5, 3.0)
val clippedToRangeSpeed = speed.clipToRange(0.5, 5.0)
// to stop the issue 1.2000000000000002
val roundedSpeed = round(clippedToRangeSpeed * 10.0) / 10.0
effects.playbackSpeed = roundedSpeed
Expand Down