-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase limit on playback speed to 5.0 #1645
Conversation
This is unlikely to be merged as it leads to too much tapping, can you do something about it , I am also working on a redesigned playback FX player to justify a speed increase to 5.0, if you can implement that then i would say we can go to 5x 😉 |
🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏 |
@MiSikora What are your thoughts on this? |
If you're asking about my opinion I feel that it is too much but I don't have any problems with having it in the app. I'll ask internally if it is something that we want to support and get back to you. However, this code on its own isn't enough. It needs changes that will support speed toggling from notification center and Tasker support for these settings. |
@zimmerrol We can add it. However, as I mentioned, you need to add support for notifications center and Tasker plugin. Notifications are handled here Lines 435 to 462 in 2ea0725
Lines 738 to 750 in 2ea0725
And Tasker is handled here Lines 46 to 48 in 2ea0725
|
Great, thanks for looking into this @MiSikora. I'll implement the necessary changes! @mebarbosa I noticed that you recently (#1862) updated all playback speed resources to ensure they all have the same font family; since we now need resources for the added speed values, I was wondering whether you could tell me how you created these images (based on what template) so that I can create the missing ones. |
@zimmerrol thanks for the ping and working on this! ❤️ I think our design @david-gonzalez-a8c could help us with this. David generated all images for me |
@mebarbosa see my comment above, David actually gave me some feedback from a design I did a few months ago 😅 😉 |
@david-gonzalez-a8c Did you have a chance for looking at this PR or can you please send me the templates you created/used? So that we can finalize this PR? |
Hey there, @zimmerrol Let me know how these look and if you need a different file structure or naming: Thank you! |
@david-gonzalez-a8c I'm still a tad unsure going up to 5x speed would be good without a redesign on safety grounds & tapping +- is very laborious beyond even 3x speed 😅 just a reminder of our chat from last year #1150 |
@MiSikora I implemented your suggestions above and think this should complete the PR. Is there anything else that needs to be done before this can get merged? Here is an example of how the new speeds are correctly displayed in the notifications: |
.../features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/EffectsFragment.kt
Outdated
Show resolved
Hide resolved
modules/services/images/src/main/res/drawable-xxxhdpi/auto_5.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
If you wouldn't mind could you sync with main
and add this to the changelog? Something like:
* Updates:
* Playback speed can now be changed up to 5x.
([#1645](https://github.com/Automattic/pocket-casts-android/pull/1645))
These tests are failing
|
Description
This PR increases the maximum playback speed from 3.0 to 5.0. The current maximum speed (3.0) can still be perceived as rather slow for podcasts with very slow speakers. Thus, this PR increases the upper bound from 3.0 to 5.0.
Testing Instructions
Screenshot
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...