Fix scroll indicator behind player for long episode lists

[rviljoen]

Fixes #1072

When scrolling long episode lists, the vertical scroll bar indicator no longer disappears behind the mini player when you get to the bottom of the list

To test

1. Open current build and find long episode list (100+ should do)
2. As you scroll to the bottom, notice that the vertical scroll indicator moves beyond the bottom of the episode list. If you scroll down far enough, it will disappear completely.

3. Build with the changes in this PR and repeat the steps above. Notice that the scroll indicator now stays above the mini player

4. Repeat the same test with episode list in multi-select mode enabled

Checklist

• I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
• I have considered adding unit tests for my changes.
• I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

[leandroalonso]

@rviljoen this is a step forward in fixing this issue, however when the mini player is not enabled this feels like a bug to me:

Simulator.Screen.Recording.-.iPhone.15.-.2023-11-23.at.13.36.17.mp4

For SwiftUI we created the MiniPlayerPadding view modifier.

I wonder if we can apply something similar here?

Ps.: we also have the same issue on Profile > Starred/Downloaded/Listening History. We don't necessarily need to tackle this here but it doesn't fix the issue in all places.

[rviljoen]

@leandroalonso Good feedback, thanks. I'll take a look.

[emilylaguna]

👋 If it helps, there is a common UITableView extension that applies the mini player padding in other areas in the app:

pocket-casts-ios/podcasts/UITableView+MiniPlayer.swift

Line 4 in cde718f

func applyInsetForMiniPlayer(additionalBottomInset: CGFloat = 0) {

[rviljoen]

I played around some more and it turns out that fixing this may require a bit more effort and testing than what it is worth for fixing a relatively small visual glitch. I have closed the PR for now and may relook at it in future.