Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categories: Remove truncation for sponsored podcasts description #1717

Merged
merged 1 commit into from
May 6, 2024
Merged

Categories: Remove truncation for sponsored podcasts description #1717

merged 1 commit into from
May 6, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented May 6, 2024 •
edited
Loading

Removes the truncation of sponsored podcast cells in Discover

Before After
Simulator Screenshot - iPhone 15 - 2024-05-06 at 12 25 34 Simulator Screenshot - iPhone 15 - 2024-05-06 at 12 24 56

To test

  • Open Discover
  • Tap on a Category
  • Ensure that the sponsored podcast shows its full description

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus requested a review from a team as a code owner May 6, 2024 18:23
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team May 6, 2024 18:23
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@bjtitus bjtitus changed the title Categories: Remove truncated sponsored podcasts Categories: Remove truncation for sponsored podcasts description May 6, 2024
@bjtitus bjtitus requested a review from leandroalonso May 6, 2024 18:30
@bjtitus bjtitus merged commit 97de69c into release/7.62.1 May 6, 2024
7 of 9 checks passed
@bjtitus bjtitus deleted the bjtitus/categories/truncated-sponsored branch May 6, 2024 18:45
@bjtitus bjtitus restored the bjtitus/categories/truncated-sponsored branch May 6, 2024 22:04
@bjtitus bjtitus mentioned this pull request May 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao SergioEstevao was automatically assigned from Automattic/pocket-casts-ios

Assignees
No one assigned
Labels
Categories Redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjtitus @dangermattic @leandroalonso