Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow space for the Support Text box on iPhone SE #330

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Sep 30, 2022

Fixes #299

Tighten up the spacing for the feedback screen and set a min-height for the description box.

To test

On an iPhone SE, navigate to the feedback or support screen (Profile > Settings > Help & Feedback > Get In touch > Select either option (Feedback or support))

Make sure you can input text for the description and that adding enough lines will allow the description field to start scrolling.

Note: This screen was originally designed by myself in a Hack week project and could probably use some ❤️ from a designer 😄

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@chipsnyder chipsnyder marked this pull request as ready for review September 30, 2022 18:27
@chipsnyder chipsnyder requested a review from a team as a code owner September 30, 2022 18:27
@chipsnyder chipsnyder added the [Type] Bug Used for issues where something is not functioning as intended. label Sep 30, 2022
@chipsnyder chipsnyder added this to the 7.24 milestone Sep 30, 2022
@leandroalonso leandroalonso self-assigned this Sep 30, 2022
@chipsnyder chipsnyder merged commit de1435f into trunk Sep 30, 2022
@chipsnyder chipsnyder deleted the issue/299-support-txt branch September 30, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Enter Support Request
2 participants