Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log initial publish event for questions #2709

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

jom
Copy link
Member

@jom jom commented Jun 4, 2019

Fixes #2668

Adds logging for when a question is initially published from either the lesson edit screen or from the add question screen.

Testing Instructions

  • Create various types of questions in WP Admin from Questions > Add New.

  • Verify sensei_question_add event is fired with the question_type property set to the type of question selected and page set to question.

  • In both classic editor and block editor, create various types of questions in WP Admin while editing a published lesson.

  • Verify sensei_question_add event is fired with the question_type property set to the type of question selected and page set to lesson.

@jom jom added this to the 2.1.0 milestone Jun 4, 2019
@jom jom requested review from alexsanford and donnapep June 4, 2019 18:21
@jom jom self-assigned this Jun 4, 2019
@jom jom changed the base branch from add/logging-course-initial-publish to master June 4, 2019 21:41
@jom jom marked this pull request as ready for review June 4, 2019 21:42
Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jom jom merged commit 8800688 into master Jun 7, 2019
@jom jom deleted the add/logging-question-initial-publish branch June 7, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log when a question is added [M]
3 participants