-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing deprecation notices #2974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should use the current version for deprecation otherwise we will remove these functions too early.
I agree with @gkaragia about the version. And the rest LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason that I asked for this is to make sure that it takes 2 major version bumps before removing the methods. It's totally fine if we add the changes to the 5.0 ticket and make sure that we don't remove them earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also just add these to a Remove deprecated stuff for 5.0 ticket and track it that way.
I think it makes sense! Just to prevent a mistake, maybe we could also add a comment like this: https://github.com/Automattic/sensei-wc-paid-courses/blob/master/includes/woocommerce-integrations/class-sensei-wc.php#L739
WDYT?
Yup that's a good idea! |
Some methods only had a
@deprecated
tag with no user-facing warning. This adds the appropriate_deprecated_function
calls.Sensei_Learner_Management::get_learner_full_name
- replaced bySensei_Learner::get_full_name
Sensei_Frontend::sensei_get_template_part
- replaced bySensei_Templates::get_part
Sensei_Frontend::sensei_course_image
- replaced bySensei()->course->course_image
Sensei_Frontend::sensei_lesson_image
- replaced bySensei()->lesson->lesson_image
Sensei_Frontend::sensei_lesson_quiz_meta
- replaced bySensei_Lesson::footer_quiz_call_to_action
Sensei_Utils::sensei_save_quiz_answers
- replaced bySensei_Quiz::save_user_answers
Sensei_Utils::sensei_grade_quiz_auto
- replaced bySensei_Grading::grade_quiz_auto
Sensei_Utils::sensei_grade_question_auto
- replaced bySensei_Grading::grade_question_auto
Sensei_Utils::sensei_get_user_question_answer_notes
- replaced bySensei()->quiz->get_user_question_feedback
quiz_questions
- replaced bySensei_Templates::get_template
sensei_check_prerequisite_course
- replaced bySensei_Course::is_prerequisite_complete
Testing instructions:
WP_DEBUG
is on.