Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix learner filters when no users should be returned #2996

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Fix learner filters when no users should be returned #2996

merged 1 commit into from
Mar 30, 2020

Conversation

jom
Copy link
Member

@jom jom commented Mar 30, 2020

Fixes #2995

Changes proposed in this Pull Request:

  • Fixes issue with learner management filters when no users should be returned.

Testing instructions:

  • Attach a simple product to a course.
  • Create a Completed order for the simple product for a user.
  • In Learner Management, check that the user is enrolled in the course.
  • Make sure no manual users are enrolled
  • Filter by Manually Enrolled Learners.

@jom jom added this to the 3.0.0 milestone Mar 30, 2020
@jom jom requested a review from a team March 30, 2020 12:42
@jom jom self-assigned this Mar 30, 2020
@jom jom merged commit 951152a into master Mar 30, 2020
@jom jom deleted the fix/empty-enrolled-users branch March 30, 2020 14:13
@donnapep donnapep changed the title Learner Management: Fix learner filters when no users should be returned Fix learner filters when no users should be returned Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnapep donnapep donnapep approved these changes

Assignees

@jom jom

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

"Manually Enrolled Learners" shows learners who were enrolled by another provider
2 participants
@jom @donnapep