Redirect to sample course after importing it #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jom
reviewed
Aug 21, 2020
| @@ -78,6 +79,7 @@ private function __construct() { | |||
| */ | |||
| public function init() { | |||
| add_action( 'init', [ $this, 'maybe_schedule_cron_jobs' ] ); | |||
| add_action( 'init', [ $this, 'redirect_imported_sample' ], 101 ); | |||
There was a problem hiding this comment.
Does this redirect work on admin_init or is it too late? If it works, it might be nice to limit the amount this is called.
There was a problem hiding this comment.
Good idea! It works!
Updated here: 7932346
renatho
force-pushed
the
change/sample-redirect-2
branch
from
14193fa
to
5147212
Compare
renatho
force-pushed
the
change/sample-redirect-2
branch
from
5147212
to
5aa6530
Compare
renatho
force-pushed
the
change/sample-redirect-2
branch
from
5aa6530
to
54aa8dd
Compare
renatho
force-pushed
the
change/sample-redirect-2
branch
from
678cdbd
to
d29524e
Compare
jom
approved these changes
Aug 21, 2020
donnapep
changed the title
donnapep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3535
Changes proposed in this Pull Request
@donnapep asked here to redirect the user to the imported course after the sample course installing.
Talking with @jom, as an alternative to #3535, we decided to go with a solution with less code. With that, we're trusting that our sample will always have an ID. (We created a test to ensure)
Testing instructions
Install a sample course.