Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base for course outline content #3584

Merged
merged 32 commits into from
Sep 9, 2020
Merged

Base for course outline content #3584

merged 32 commits into from
Sep 9, 2020

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Sep 3, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • This PR introduces the base for the course outline content.
  • It's getting the content from a mocked array (in both frontend and editor) until we have the API.
  • This PR removes the legacy list when the course outline block is rendering. But this approach is temporary until we research the best approach.
  • This PR still doesn't handle the styles, different lessons statuses, and other specific interactions.

Testing instructions

  • Create a new course.
  • Interact with the outline block to make sure everything is working properly.
  • Save the course with the outline block.
  • Go to the frontend and make sure the course appears correctly (the data won't still match the correct content, it's getting a mocked array until we have the API).

Screenshot / Video

Editor:

Screen Shot 2020-09-03 at 18 06 06

Frontend:

Screen Shot 2020-09-03 at 18 06 30

@renatho renatho added this to the 3.6.0 milestone Sep 3, 2020
@renatho renatho self-assigned this Sep 3, 2020
@renatho renatho marked this pull request as ready for review September 4, 2020 19:07
@renatho renatho requested a review from a team September 4, 2020 19:07
yscik
yscik reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few comments on naming, and some missing jsdocs.

assets/blocks/course-outline/lesson-block/edit.js Outdated Show resolved Hide resolved
assets/blocks/course-outline/edit.js Outdated Show resolved Hide resolved
assets/blocks/course-outline/lesson-block/edit.js Outdated Show resolved Hide resolved
assets/blocks/course-outline/module-block/edit.js Outdated Show resolved Hide resolved
assets/blocks/course-outline/use-block-creator.js Show resolved Hide resolved
@renatho renatho mentioned this pull request Sep 8, 2020
Merged
@renatho
Add editor styles
f6edfa6
@renatho
Refactor separating edit blocks
398e5ec
@renatho
Refactor clean input class
19599e8
@renatho
Update outline block adding content dinamically
964c1b7
@renatho
Refactor blocks creator
466f29e
@renatho
Add attributes update
5415698
@renatho
Add lessons title translation
17c5180
@renatho
Remove unused class
ab5bb8f
@renatho
Add outline content do the server render
de2258b
@renatho
Update styles so editor and frontend spacings match
2c0f265
@renatho
Update module description to RichText
f13edda
@renatho
Update lesson to be link in the frontend
e653fe7
@renatho
Fix semantic
45245ce 
It was necessary to override some native classes to use a
better semantic.
@renatho
Update module lessons title
69637ad 
Hide the title in the frontend when there are no lessons.
@renatho
Fix module description field
5f971b8
@renatho
Update blocks creator to skip when there are no blocks
c988848
@renatho
Refactor single line input
b9ae14a
@renatho
Add new lesson when pressing enter
849f7d2 
It happens when the user is with the focus in the last lesson from
a list (in the module or out).
@renatho
Add some documentation to the course outline block
cd59c5a
@renatho
Refactor lesson keyup handler
4818965
@renatho
Convert dark gray in variable
ea53ad8
@renatho
Refactor event handlers
12b4ebe
@renatho
Update edit components naming
6e23f24 
Use a specific naming to make debugging easier.
@renatho renatho requested a review from yscik September 8, 2020 19:24
yscik
yscik approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@renatho renatho merged commit 31712f1 into master Sep 9, 2020
@renatho renatho deleted the add/course-outline-content branch September 9, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yscik yscik yscik approved these changes

Assignees

@renatho renatho

Labels
[Type] Enhancement
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@renatho @yscik