Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inner block attributes #3615

Merged
merged 14 commits into from
Sep 16, 2020
Merged

Add support for inner block attributes #3615

merged 14 commits into from
Sep 16, 2020

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Sep 15, 2020

Changes proposed in this Pull Request

  • Render block based on the course structure data
  • Add a blocks attribute to the Outline block, containing attributes for it's inner blocks
    • This is indexed by lesson/modules id, like lesson-13. This way, if things are modified/reordered outside the block editor, the renderer can still use the style & block-level settings set for that lesson/module.
  • Merge with existing blocks in the editor when loading the course structure data from the backend. (Preserve their attributes.)

Testing instructions

  • Create a course, add modules and lessons, save
  • View course, check that those modules and lessons are displayed in the frontend.
    --
  • The attributes stuff is mostly infrastructure, actual usage for block styling will be in separate PRs.

Screenshot / Video

Teaser:

image

@yscik yscik requested a review from a team September 15, 2020 12:58
@yscik yscik added this to the 3.6.0 milestone Sep 15, 2020
@jom
Copy link
Member

jom commented Sep 15, 2020

I'll hold off approving until the dependent PRs get merged, but in principle this looks good! ✅

@yscik yscik force-pushed the add/course-outline-api-client branch from c4b3779 to 95faa1a Compare September 15, 2020 17:21
Base automatically changed from add/course-outline-api-client to master September 15, 2020 19:53
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yscik yscik merged commit b11af6f into master Sep 16, 2020
@yscik yscik deleted the add/course-block-styles branch September 16, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants