Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure quiz settings are preserved when saving lesson #3632

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Ensure quiz settings are preserved when saving lesson #3632

merged 2 commits into from
Sep 24, 2020

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Sep 18, 2020

Fixes #3582

Changes proposed in this Pull Request

This solution is a bit hacky, but I think it's enough until we refactor this part.

Testing instructions

  • Create a lesson.
  • Edit the lesson.
  • Scroll until the quiz settings.
  • Uncheck Pass required to complete lesson and _ Allow user to retake the quiz_.
  • Save the lesson.
  • Refreshes the page, and make sure it's still unchecked.
  • Check the same options, refresh the page and make sure it's checked.
  • Go to the All Lessons page in WP-admin.
  • Hover the same lesson and click on Quick Edit.
  • Mark the option -- No change -- in the fields Pass required and Enable quiz reset button, and make sure it didn't change.
  • Try to save the Quick Edit fields and the Lesson post, and make sure the data are properly saved in all situations.

@renatho renatho added this to the 3.5.2 milestone Sep 18, 2020
@renatho renatho self-assigned this Sep 18, 2020
@renatho renatho mentioned this pull request Sep 18, 2020
Merged
gikaragia
gikaragia approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well!

@renatho renatho merged commit 2414160 into release/3.5.2 Sep 24, 2020
@renatho renatho deleted the fix/quiz-settings branch September 24, 2020 14:37
@donnapep donnapep changed the title Fix quiz settings Ensure quiz settings are preserved when saving lesson Sep 29, 2020
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Aug 9, 2022
@renatho @saas786
Merge pull request Automattic#3632 from Automattic/fix/quiz-settings
5ecd4d9 
Fix quiz settings
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Aug 9, 2022
@renatho @saas786
Merge pull request Automattic#3632 from Automattic/fix/quiz-settings
e911cd2 
Fix quiz settings
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Aug 9, 2022
@renatho @saas786
Merge pull request Automattic#3632 from Automattic/fix/quiz-settings
114d2c2 
Fix quiz settings
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Aug 9, 2022
@renatho @saas786
refactor: merge pull request Automattic#3632 from Automattic/fix/quiz…
9cc059b 
…-settings

* Fix quiz settings
* Automattic@2414160
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Aug 9, 2022
@renatho @saas786
refactor: merge pull request Automattic#3632 from Automattic/fix/quiz…
d1a874f 
…-settings

* Fix quiz settings
* Automattic@2414160
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Aug 10, 2022
@renatho @saas786
refactor: merge pull request Automattic#3632 from Automattic/fix/quiz…
b2e21fb 
…-settings

* Fix quiz settings
* Automattic@2414160
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Aug 10, 2022
@renatho @saas786
refactor: merge pull request Automattic#3632 from Automattic/fix/quiz…
2f0ea63 
…-settings

* Fix quiz settings
* Automattic@2414160
saas786 pushed a commit to conversionxl/sensei that referenced this pull request Sep 22, 2022
@renatho @saas786
refactor: merge pull request Automattic#3632 from Automattic/fix/quiz…
4f30a8a 
…-settings

* Fix quiz settings
* Automattic@2414160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia approved these changes

@donnapep donnapep Awaiting requested review from donnapep

@yscik yscik Awaiting requested review from yscik

Assignees

@renatho renatho

Labels
[Type] Bug
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@renatho @gikaragia