Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with cleared alignment in Take Course block #3764

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Fix issue with cleared alignment in Take Course block #3764

merged 4 commits into from
Nov 9, 2020

Conversation

gikaragia
Copy link
Contributor

@gikaragia gikaragia commented Nov 9, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • There was an issue with the 'Take course' block and its alignment control. To reproduce it, select the already selected alignment option in the block and observe that the element gets full width.
  • The cause of this is that when the same option is selected, the selected class gets cleared.
  • With this fix, when the same option is selected no changes are applied to the block.
  • There are also a few fixes in Travis to make build work again.

Testing instructions

  • Add a 'Take course' block.
  • Select the already selected alignment option in the block.
  • Observe that there is no change.
  • Check that the alignment is correct in the frontend.

@gikaragia gikaragia changed the title Do not allow use to clear the alignment Do not allow user to clear the alignment Nov 9, 2020
@gikaragia gikaragia requested a review from a team November 9, 2020 09:26
@gikaragia gikaragia added this to the 3.6.0 milestone Nov 9, 2020
@gikaragia gikaragia mentioned this pull request Nov 9, 2020
Merged
@gikaragia gikaragia marked this pull request as draft November 9, 2020 10:35
@gikaragia gikaragia removed the request for review from a team November 9, 2020 10:35
@gikaragia gikaragia requested a review from a team November 9, 2020 11:06
@gikaragia gikaragia marked this pull request as ready for review November 9, 2020 11:07
yscik
yscik approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gikaragia gikaragia merged commit 46532f5 into master Nov 9, 2020
@donnapep donnapep deleted the fix/alignment-empty-issue branch November 10, 2020 13:29
@donnapep donnapep changed the title Do not allow user to clear the alignment Fix issue with cleared alignment in Take Course block Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yscik yscik yscik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gikaragia @yscik