Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gap Fill question block #3974

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Add Gap Fill question block #3974

merged 2 commits into from
Feb 15, 2021

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Feb 12, 2021 •
edited
Loading

Depends on #3967 for some shared changes

Changes proposed in this Pull Request

  • Add answer section for Gap Fill question type
  • Has a Text before, text after rich text fields
  • And a token field for the right answers
  • Add a hint for the token field when the block is focused (Add right answers. Separate with commas or the Enter key.)

Testing instructions

  • Add a quiz to a lesson and set a question's type to Gap Fill
  • Fill in the editable areas and he right answers
  • Check that everything works well and feels right

Screenshot / Video

image

@yscik yscik added this to the 3.9.0 milestone Feb 12, 2021
@yscik yscik requested a review from a team February 12, 2021 16:54
@yscik yscik changed the base branch from master to add/multichoice-question-block February 12, 2021 17:37
@yscik @jom
Fix attribute rename
22b9162 
Co-authored-by: Jake Oehler Morrison <jake.morrison@automattic.com>
@yscik yscik merged commit 2acb9d5 into add/multichoice-question-block Feb 15, 2021
@yscik yscik deleted the add/gapfill-question-block branch February 15, 2021 14:34
@yscik yscik restored the add/gapfill-question-block branch February 15, 2021 14:36
@yscik yscik mentioned this pull request Feb 15, 2021
Merged
4 tasks
@yscik yscik deleted the add/gapfill-question-block branch February 15, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yscik @jom