Use block button styles for quiz actions #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The buttons appear to be stacking for me regardless of which theme I try. Following screenshot is Twenty Twenty One:
|
|
Added the CSS to display correctly in all cases @ a25f369 |
jom
reviewed
Mar 5, 2021
includes/class-sensei-quiz.php
Outdated
|
|
||
| <?php } // End If Statement ?> | ||
|
|
||
| <?php if ( isset( $reset_quiz_allowed ) && $reset_quiz_allowed ) { ?> | ||
| <?php if ( true || isset( $reset_quiz_allowed ) && $reset_quiz_allowed ) { ?> |
jom
reviewed
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3973
This is a temporary solution to make sure that buttons on the quiz page don't stand out for new courses that use block-based buttons everywhere else. We'll want to to a wider revamp of Sensei's frontend styles in the future.
Changes proposed in this Pull Request
Testing instructions
Compatibility, template changes
While this change tries to not break things, some custom CSS made for Sensei buttons might have to be updated:
input[type=submit]=>button).quiz=>.quiz:not(.quiz-blocks))Screenshot / Video
Blocks:
Not blocks: