Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak extensions page design #4185

Merged
merged 6 commits into from
Apr 14, 2021
Merged

Tweak extensions page design #4185

merged 6 commits into from
Apr 14, 2021

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Apr 13, 2021

Based on #4180

Changes proposed in this Pull Request

  • It fixes some design issues.
    • Fix button color.
    • Update button min size.
    • Fix grid (other tabs) issue in small resolutions.
    • Fix the position of the buttons in the large list.
    • Update responsive break to the same WordPress break.
    • Tweak the featured list to have an additional responsive break (2 items per line).

Testing instructions

  • Go to wp-admin > Sensei LMS > Extensions, and check the page design.

Screenshot / Video

Screen.Recording.2021-04-13.at.15.32.34.mov

@renatho renatho added this to the 3.11.0 milestone Apr 13, 2021
@renatho renatho requested a review from a team April 13, 2021 18:38
@renatho renatho self-assigned this Apr 13, 2021
@renatho renatho changed the title Tweak design styles Tweak extensions page design Apr 13, 2021
gikaragia
gikaragia approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@renatho renatho merged commit 5ee6c37 into add/extension-card-logic Apr 14, 2021
@renatho renatho deleted the fix/design-styles branch April 14, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia approved these changes

Assignees

@renatho renatho

Labels
[Type] Enhancement
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@renatho @gikaragia