Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learner Courses block styling issues #4298

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Learner Courses block styling issues #4298

merged 2 commits into from
Sep 3, 2021

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Sep 2, 2021 •
edited
Loading

Changes proposed in this Pull Request

  • Adds 16px of padding around the cards in the Learner Courses block (as requested here).
  • Moves buttons to a new line if there is not enough space to display them side-by-side (as reported here).

Testing instructions

  • Activate the Certificates extension.
  • Test the Learner Courses block on multiple themes and ensure the View Results and View Certificate buttons stack when there is not enough space.

Screenshot / Video

Twenty Twenty-One

Before

Screen Shot 2021-09-02 at 4 01 01 PM

After

Screen Shot 2021-09-02 at 3 57 35 PM

@donnapep donnapep added this to the 3.13.2 milestone Sep 2, 2021
@donnapep donnapep self-assigned this Sep 2, 2021
@donnapep donnapep requested review from sruj09 and a team September 2, 2021 20:02
renatho
renatho approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well!

@donnapep donnapep merged commit 44a92c5 into master Sep 3, 2021
@donnapep donnapep deleted the tweak/learner-courses-padding branch September 3, 2021 20:42
@sruj09
Copy link

sruj09 commented Sep 3, 2021

Looks so much better! 🙌

@renatho renatho modified the milestones: 3.13.2, 3.13.3 Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatho renatho renatho approved these changes

@sruj09 sruj09 Awaiting requested review from sruj09

Assignees

@donnapep donnapep

Labels
None yet
Projects
None yet
Milestone
3.13.3
Development

Successfully merging this pull request may close these issues.
3 participants
@donnapep @sruj09 @renatho