Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add course list filter block to patterns #5612

Merged
merged 10 commits into from
Sep 9, 2022

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Sep 8, 2022

Implements #5587

Changes proposed in this Pull Request

  • Added the Course List Filter block in the patterns

Testing instructions

  • Add a Course List block in any GB editor page
  • Try choosing a pattern
  • Make sure both patterns show up with 3 filters on top
  • Make sure they stay after selecting
  • Make sure they render as expected on the frontend

@Imran92 Imran92 requested a review from a team September 8, 2022 21:29
@Imran92 Imran92 self-assigned this Sep 8, 2022
@Imran92 Imran92 linked an issue Sep 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #5612 (2cb040b) into feature/course-list (7c87a09) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             feature/course-list    #5612   +/-   ##
======================================================
  Coverage                  44.71%   44.72%           
- Complexity                  8837     8840    +3     
======================================================
  Files                        426      426           
  Lines                      31568    31574    +6     
  Branches                     245      245           
======================================================
+ Hits                       14116    14121    +5     
- Misses                     17274    17275    +1     
  Partials                     178      178           
Impacted Files Coverage Δ
...e-list/class-sensei-course-list-block-patterns.php 0.00% <ø> (ø)
...rse-list/class-sensei-course-list-filter-block.php 91.11% <0.00%> (-1.39%) ⬇️
...ourse-list-filter-block/course-list-filter-edit.js 57.14% <0.00%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c87a09...2cb040b. Read the comment docs.

Base automatically changed from add/course-list-student-course-filter to feature/course-list September 9, 2022 09:15
@donnapep
Copy link
Collaborator

donnapep commented Sep 9, 2022

Looks like there's an e2e test failure. PR tests well though!

@Imran92
Copy link
Contributor Author

Imran92 commented Sep 9, 2022

Thanks a lot for helping with the e2e @gabrielcaires :fistbump

@Imran92 Imran92 merged commit 6b57dd9 into feature/course-list Sep 9, 2022
@Imran92 Imran92 deleted the add/course-list-filter-to-pattern branch September 9, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update patterns with Filter blocks
3 participants