Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded icon font formats #5655

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Remove unneeded icon font formats #5655

merged 2 commits into from
Sep 14, 2022

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Sep 12, 2022

Fixes 1779-gh-Automattic/sensei-pro

Changes proposed in this Pull Request

  • Remove all but .woff format from the CSS loading Fontawesome and Sensei icon font family
  • The various formats were originally for supporting old browsers, but everything now supports WOFF (including IE)
  • This fixes an issues in Sensei Pro, where the SVG was being inlined and base64-encoded, resulting in a huge file:
  • sensei-fontawesome.css: 476kB → 1kB

Testing instructions

  • Check that icons are still visible
  • Example pages: course in progress, completed lesson:

image

image

@yscik yscik requested review from renatho and a team September 12, 2022 15:07
@codecov

This comment was marked as resolved.

Sign in to view
fjorgemota
fjorgemota previously approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@fjorgemota fjorgemota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. Good catch!

renatho
renatho reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for working on that!

Just one small suggestion about the font type.

assets/css/fontawesome.scss Outdated Show resolved Hide resolved
renatho
renatho approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fjorgemota fjorgemota self-requested a review September 14, 2022 14:29
fjorgemota
fjorgemota approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@fjorgemota fjorgemota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yscik yscik merged commit 6a24404 into trunk Sep 14, 2022
@yscik yscik deleted the fix/fontawesome-bundle branch September 14, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjorgemota fjorgemota fjorgemota approved these changes

@renatho renatho renatho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yscik @fjorgemota @renatho