Skip to content

Commit

Permalink
Merge Release/1.10.0 into develop (#1689)
Browse files Browse the repository at this point in the history
* Update version in package.json for 1.10.0 release

Added the beta version for 1.10.0-beta1 release

* Fix/only run notes loaded when notes loaded (#1680)

* Only run notesLoaded when notes are indeed loaded

After querying the noteBucket we run notes loaded with an empty notes array. This causes havoc because we rely on notes being null until notes are loaded. This commit adds a check to ensure there is at least one note before running notesLoaded

* Add release notes

* Update RELEASE-NOTES.txt

* Update signing certificate (#1682)

Props to @loremattei for creating these changes

* Bump version to v1.10.0-beta2 (#1684)

* Add version for release 1.10.0
  • Loading branch information
loremattei authored and belcherj committed Nov 4, 2019
1 parent f6ac7ed commit a52ad14
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion RELEASE-NOTES.txt
@@ -1,6 +1,6 @@
# Changelog

## Future release
## [v1.10.0]

### Enhancements

Expand All @@ -14,6 +14,7 @@
- Rework WordPress.com signin to prevent infinite looping and login failures [#1627](https://github.com/Automattic/simplenote-electron/pull/1627)
- Fixed bug that only shows the first line of text in note list preview [#1647](https://github.com/Automattic/simplenote-electron/pull/1647)
- Update link to release-notes in updater config: CHANGELOG -> RELEASE_NOTES
- Stop showing that there are no notes when initially loading notes from the server. [#1680](https://github.com/Automattic/simplenote-electron/pull/1680)

### Other changes

Expand Down
1 change: 0 additions & 1 deletion after_sign_hook.js
Expand Up @@ -7,7 +7,6 @@ module.exports = async function(params) {
if (process.platform !== 'darwin') {
return;
}
console.log('afterSign hook triggered', params);

if (!process.env.CIRCLE_TAG || process.env.CIRCLE_TAG.length === 0) {
console.log('Not on a tag. Skipping notarization');
Expand Down
4 changes: 3 additions & 1 deletion lib/flux/app-state.js
Expand Up @@ -266,7 +266,9 @@ export const actionMap = new ActionMap({
cursor.continue();
} else {
debug(`noteCount: ${notes.length}`);
dispatch(this.action('notesLoaded', { notes: notes }));
if (notes.length) {
dispatch(this.action('notesLoaded', { notes: notes }));
}
}
};
});
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -6,7 +6,7 @@
"email": "support@simplenote.com"
},
"productName": "Simplenote",
"version": "1.9.1",
"version": "1.10.0",
"main": "desktop/index.js",
"license": "GPL-2.0",
"homepage": "https://simplenote.com",
Expand Down
Binary file modified resources/certificates/mac.p12.enc
Binary file not shown.

0 comments on commit a52ad14

Please sign in to comment.