-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Check for Updates" menu item #1090
Conversation
5b8c1a3
to
c019394
Compare
039afc5
to
55ca6b9
Compare
This may happen if the GitHub API call flaked out on the user-initiated check, but succeeded on the check that happens automatically on application launch. In this case, you would not have seen a download progress window — just a dialog that says an update is ready to be installed. |
Ah ok 👍 |
Closes #1041
Currently, the app checks for updates on launch, downloads it in the background, and only prompts the user when the download is completed. This was a good "minimum viable" UX because the built-in Electron dialogs don't allow dynamic updating to show download progress, and the app takes a significant amount of time to download.
This PR enhances that minimum implementation by adding a "Check for Updates" menu item. Users can now manually check if they're using the latest version, and this also lays the groundwork for a "don't check for updates" option (#842) that we should add next.
Test builds
Should say that no updates are available:
Note: The icon in the Linux dialog is broken. This is a known bug, and will be fixed when we update to Electron >=2.0.13.
Should download an update:
~/Library/Application Support/Simplenote/__update__/
, if you would like to remove it.)