Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Check for Updates" menu item #1090

Merged
merged 13 commits into from
Jan 15, 2019
Merged

Add "Check for Updates" menu item #1090

merged 13 commits into from
Jan 15, 2019

Conversation

mirka
Copy link
Member

@mirka mirka commented Dec 10, 2018

Closes #1041

Currently, the app checks for updates on launch, downloads it in the background, and only prompts the user when the download is completed. This was a good "minimum viable" UX because the built-in Electron dialogs don't allow dynamic updating to show download progress, and the app takes a significant amount of time to download.

This PR enhances that minimum implementation by adding a "Check for Updates" menu item. Users can now manually check if they're using the latest version, and this also lays the groundwork for a "don't check for updates" option (#842) that we should add next.

Test builds

Should say that no updates are available:

Note: The icon in the Linux dialog is broken. This is a known bug, and will be fixed when we update to Electron >=2.0.13.

Should download an update:

  • Windows
  • Linux
  • Mac (For it to actually install the downloaded update, the Simplenote app must be in the Applications folder. FYI the downloaded update is saved in ~/Library/Application Support/Simplenote/__update__/, if you would like to remove it.)

@mirka mirka changed the title [WIP] Add "Check for Updates" menu item Add "Check for Updates" menu item Dec 20, 2018
@mirka mirka requested a review from roundhill December 20, 2018 16:52
@roundhill
Copy link
Contributor

For a bit on Windows 7, I got this message:

screen shot 2019-01-09 at 3 30 35 pm

After maybe 10 seconds, it did download the update though 🤔 Let me know if you can reproduce that.

@mirka
Copy link
Member Author

mirka commented Jan 14, 2019

After maybe 10 seconds, it did download the update though 🤔 Let me know if you can reproduce that.

This may happen if the GitHub API call flaked out on the user-initiated check, but succeeded on the check that happens automatically on application launch. In this case, you would not have seen a download progress window — just a dialog that says an update is ready to be installed.

@roundhill
Copy link
Contributor

This may happen if the GitHub API call flaked out on the user-initiated check, but succeeded on the check that happens automatically on application launch. In this case, you would not have seen a download progress window — just a dialog that says an update is ready to be installed.

Ah ok 👍

@mirka mirka merged commit ef1e0d3 into master Jan 15, 2019
@mirka mirka deleted the feature/check-for-updates branch January 15, 2019 09:32
@mirka mirka mentioned this pull request Jan 24, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Check for Updates" option in the Windows app
2 participants