Fix CJK-related crashes after tab character #1171
Conversation
|
Pretty sure there's a bug with this where characters get duplicated, I can't reproduce this in
|
Gaaah. I can reproduce it in Despite this, I think we should merge in this PR for v1.4.0 as a band-aid while we work to get the Electron update out ASAP. Two reasons:
Thoughts? |
I agree, duplicated content is better than a WSOD. And we'll have it really fixed soon enough with the electron update. |
| */ | ||
| const tabDecorator = () => { | ||
| const strategy = (contentBlock, callback) => { | ||
| const tabRegex = /\t/g; |
There was a problem hiding this comment.
One of the smallest regex I've ever seen ;)
* Update Electron to 4.0.2 * Adapt to new makeSingleInstance API * Remove unneeded shortcut for Search Notes Also conflicting with the Focus Mode shortcut (⌘⇧F) here due to a change in the KeyboardEvent. (Now needs an explicit check for shiftKey) * Fix Note List navigation shortcuts * Fix Close Note shortcut (narrow width screens) * Remove unneeded filter on menu array Rendered unnecessary by electron/electron#13992 * Update electron-builder and electron-updater # Conflicts: # package.json * Fix Select All & Copy in Markdown preview * Remove CJK crash workaround #1171 * Try electron-builder 20.38.4 * Revert "Remove unneeded filter on menu array" This reverts commit 90a94e7. * Revert electron-builder to 20.28.2 * Try electron-builder 20.33.2 * Try electron-builder 20.30.0 * Try electron-builder 20.31.2 * Try electron-builder 20.32.0 * Try electron-builder 20.33.1 * Revert "Try electron-builder 20.33.1" This reverts commit d834229.
|
The duplication glitch #1171 (comment) is now fixed in v1.5.0. |
Closes #780
Update: This seems to have been a bug in the Chrome version in Electron 2. It doesn't reproduce at all in Electron >3.0.0. So this workaround should be unnecessary once we update.
This is a really unsatisfying workaround that doesn't address any root causes and I don't like it 😐I first suspected a focus management bug in our
indentCurrentBlock()code, but as far as I could tell that doesn't seem to be the case here. Hopefully we can dig a little deeper into the issue sometime in the future, but since this is a pretty serious bug for our CJK users this workaround should help in the meantime.To test
Refer to this comment for repro steps: #780 (comment)
Note that the original bug only applies to Electron, and not Chrome/Firefox/Safari.