Add custom tooltips to toolbar buttons #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mirka
changed the title
This was referenced Feb 20, 2019
roundhill
approved these changes
Feb 26, 2019
lib/search-bar/index.jsx
Outdated
| <IconButton icon={<MenuIcon />} onClick={onToggleNavigation} title="Menu" /> | ||
| <IconButton | ||
| icon={<MenuIcon />} | ||
| disableTooltip={true} |
There was a problem hiding this comment.
Why did you disable it for the menu button?
There was a problem hiding this comment.
I was under the impression that it was a standard Material design pattern to disable tooltips on the hamburger button, but I did a little more research today and it doesn't really seem to be the case 🤔 (There's even variance in Google's own apps!)
I'm going to remove this logic to keep it simple. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These custom tooltips are a small usability enhancement over the current built-in
titletooltips.Benefits:
Related: #700 #985