Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hash to app.js to blow out cache #1543

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Add a hash to app.js to blow out cache #1543

merged 1 commit into from
Aug 19, 2019

Conversation

belcherj
Copy link
Contributor

Fix

adds hash to app.js to clear cache when updates are made.

Test

  1. Open dev tools, goto network panel
  2. Goto: https://develop.simplenote.com/
  3. Observe app.*****.js has a hash

Review

Only one developer is required to review these changes, but anyone can perform the review.

@belcherj belcherj self-assigned this Aug 19, 2019
@belcherj belcherj requested a review from sirreal August 19, 2019 20:04
bummytime
bummytime approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 :shipit: 🙇 😄

@belcherj belcherj merged commit fb4354e into develop Aug 19, 2019
@belcherj belcherj deleted the add/appjs-hash branch August 19, 2019 20:30
@mokagio mokagio mentioned this pull request Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bummytime bummytime bummytime approved these changes

@sirreal sirreal Awaiting requested review from sirreal

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@belcherj @bummytime