Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colours to color-studio.blog #1565

Merged
merged 8 commits into from
Sep 27, 2019
Merged

Update colours to color-studio.blog #1565

merged 8 commits into from
Sep 27, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Sep 11, 2019

Fix

Update CSS colors to use color-studio.blog in line with the new style guidelines.

Test

  • Verify that the app works and the colors look pretty much the same :)
  • Test in both light and dark modes

Screenshots

Before:
Screen Shot 2019-09-25 at 10 44 46 PM

After:
Screen Shot 2019-09-25 at 10 30 52 PM

Before:
Screen Shot 2019-09-25 at 10 48 10 PM

After:
Screen Shot 2019-09-25 at 10 30 01 PM

Before:
Screen Shot 2019-09-25 at 10 50 46 PM

After:
Screen Shot 2019-09-25 at 10 30 10 PM

Before:
Screen Shot 2019-09-25 at 10 47 59 PM

After:
Screen Shot 2019-09-25 at 10 30 30 PM

Release

RELEASE-NOTES.txt was updated with:

Updated colors to use Color Studio, the color palette for Automattic products

@codebykat codebykat self-assigned this Sep 12, 2019
@belcherj belcherj added this to the 1.10 milestone Sep 24, 2019
scss/_variables.scss Outdated Show resolved Hide resolved
@SylvesterWilmott
Copy link
Contributor

Looks good!

I'm unsure if you want to tackle this within this PR but the way we use colours in dark mode should ideally be adjusted for better accessibility/contrast. The rules of colour use in dark mode can be found in the Design Guidelines. Otherwise, it looks great, thanks @belcherj

@belcherj
Copy link
Contributor Author

I cannot approve since I opened the PR but the code looks and the UI seems consistent with production. I do think we have more serious contrast concerns but this is outside the scope of this PR. I think that @SylvesterWilmott is addressing these as part of a future effort.

@belcherj
Copy link
Contributor Author

Look like Sly and I was thinking the same thing. For proper attribution @codebykat did most of the heavy lifting on this PR.

Let's address the color contrast issues in another PR.

@belcherj
Copy link
Contributor Author

If there is no other comment by end of day, please merge.

@@ -8,6 +8,7 @@
- Renamed CHANGELOG.md to RELEASE-NOTES.txt
- Open new note automatically upon creation
- Open new note automatically upon creation [1566](https://github.com/Automattic/simplenote-electron/issues/1566)
- Updated colors to use Color Studio in alignment with new design guidelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I do a web search for color studio I don't find anything that would explain this. Could we add something that indicates what it is or more importantly, what impact it has on our customers?

Something like this maybe…

 - Updated colors to use Color Studio, the color palette for Automattic products

@codebykat
Copy link
Member

I cannot approve since I opened the PR but the code looks and the UI seems consistent with production. I do think we have more serious contrast concerns but this is outside the scope of this PR. I think that @SylvesterWilmott is addressing these as part of a future effort.

Yeah, I don't think dark mode is great. I fixed a few of the worst offenders in this PR (the search bar and the tag listing) but I agree it needs a more serious overhaul at a future date.

@codebykat
Copy link
Member

Did a last round of updates -- could use a smoke test but I think it's good to go and we can address the contrast in a follow-up PR.

@belcherj
Copy link
Contributor Author

Ship it!!

@codebykat codebykat merged commit 3090e09 into develop Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement Improve existing functionality [OS] web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants