-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update colours to color-studio.blog #1565
Conversation
d86e5d2
to
3b7f014
Compare
Looks good! I'm unsure if you want to tackle this within this PR but the way we use colours in dark mode should ideally be adjusted for better accessibility/contrast. The rules of colour use in dark mode can be found in the Design Guidelines. Otherwise, it looks great, thanks @belcherj |
I cannot approve since I opened the PR but the code looks and the UI seems consistent with production. I do think we have more serious contrast concerns but this is outside the scope of this PR. I think that @SylvesterWilmott is addressing these as part of a future effort. |
Look like Sly and I was thinking the same thing. For proper attribution @codebykat did most of the heavy lifting on this PR. Let's address the color contrast issues in another PR. |
If there is no other comment by end of day, please merge. |
RELEASE-NOTES.txt
Outdated
@@ -8,6 +8,7 @@ | |||
- Renamed CHANGELOG.md to RELEASE-NOTES.txt | |||
- Open new note automatically upon creation | |||
- Open new note automatically upon creation [1566](https://github.com/Automattic/simplenote-electron/issues/1566) | |||
- Updated colors to use Color Studio in alignment with new design guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I do a web search for color studio
I don't find anything that would explain this. Could we add something that indicates what it is or more importantly, what impact it has on our customers?
Something like this maybe…
- Updated colors to use Color Studio, the color palette for Automattic products
Yeah, I don't think dark mode is great. I fixed a few of the worst offenders in this PR (the search bar and the tag listing) but I agree it needs a more serious overhaul at a future date. |
Did a last round of updates -- could use a smoke test but I think it's good to go and we can address the contrast in a follow-up PR. |
Ship it!! |
Fix
Update CSS colors to use color-studio.blog in line with the new style guidelines.
Test
Screenshots
Before:
After:
Before:
After:
Before:
After:
Before:
After:
Release
RELEASE-NOTES.txt
was updated with: