Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests to Checkbox component #1580

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Add Tests to Checkbox component #1580

merged 2 commits into from
Sep 23, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Sep 21, 2019 •
edited

Fix

This PR does the following to the Checkbox component:

  • Small css cleanup
  • Adds tests

Test

  1. Add checkbox to a note
  2. Check it off
  3. Uncheck it

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Added tests to Checkbox component

@belcherj belcherj self-assigned this Sep 21, 2019
@belcherj belcherj changed the title Update and cleanup the Checkbox component Add Tests to Checkbox component Sep 23, 2019
@belcherj belcherj force-pushed the update/cleanup-checkbox-component branch from 2e488d9 to 32e0b00 Compare September 23, 2019 15:49
@belcherj belcherj marked this pull request as ready for review September 23, 2019 15:50
@belcherj belcherj requested a review from a team September 23, 2019 15:50
@belcherj belcherj merged commit 394ab29 into develop Sep 23, 2019
@belcherj belcherj deleted the update/cleanup-checkbox-component branch September 23, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@belcherj @dmsnell