Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/only run notes loaded when notes loaded #1680

Merged
merged 3 commits into from Oct 30, 2019
Merged

Fix/only run notes loaded when notes loaded #1680

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3fd166
Only run notesLoaded when notes are indeed loaded
belcherj Oct 30, 2019
e848f1b
Add release notes
belcherj Oct 30, 2019
ad80a8c
Update RELEASE-NOTES.txt
belcherj Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@

- Rework WordPress.com signin to prevent infinite looping and login failures [#1627](https://github.com/Automattic/simplenote-electron/pull/1627)
- Update link to release-notes in updater config: CHANGELOG -> RELEASE_NOTES
- Don't update notes state with an empty array causing notes to be considered loaded
belcherj marked this conversation as resolved.
Show resolved Hide resolved

## [v1.9.1]

Expand Down
4 changes: 3 additions & 1 deletion lib/flux/app-state.js
View file
Open in desktop
Expand Up @@ -266,7 +266,9 @@ export const actionMap = new ActionMap({
cursor.continue();
} else {
debug(`noteCount: ${notes.length}`);
dispatch(this.action('notesLoaded', { notes: notes }));
if (notes.length) {
dispatch(this.action('notesLoaded', { notes: notes }));
}
}
};
});
Expand Down