Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note list: Make decorator for search result highlighting case insensitive #1831

Merged
merged 2 commits into from Jan 13, 2020
Merged

Note list: Make decorator for search result highlighting case insensitive #1831

merged 2 commits into from Jan 13, 2020

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Jan 12, 2020 •
edited

Fix

This is a single-character fix for #1830.

Test

  1. Search for a single character that exists in both lower and uppercase form in your note titles
  2. Verify that, whether you enter it in lower or uppercase, both lowercase and uppercase results are highlighted in the notes list, as well as in the note content.

Review

I'm curious why we're not using the same decorator as the note-editor is using.

Release

RELEASE-NOTES.txt was updated in 7aa698e with:

Fixed a bug causing the search result highlighting in the sidebar to be case sensitive #1831

@codebykat codebykat self-assigned this Jan 12, 2020
@codebykat codebykat added this to In Review in Stable Jan 12, 2020
@codebykat codebykat requested a review from a team January 12, 2020 05:25
@codebykat codebykat merged commit 127763c into develop Jan 13, 2020
@dmsnell dmsnell deleted the fix/search-highlight-in-sidebar-is-case-sensitive branch January 13, 2020 23:53
@codebykat codebykat mentioned this pull request Jan 15, 2020
Closed
@codebykat codebykat moved this from In Review to Done in Stable Jan 15, 2020
dmsnell added a commit that referenced this pull request Jan 24, 2020
@dmsnell
Fix: Added change notes to wrong version (#1860)
d5e3f6c 
In #1831 we added the change notes to v1.14.0's notes but this fix did not make
it into the v1.14.0 release. In this patch we're moving the notes into the
future v1.15.0 release's notes.
@dmsnell dmsnell mentioned this pull request Jan 24, 2020
Merged
dmsnell added a commit that referenced this pull request Jan 24, 2020
@dmsnell
Fix: Added change notes to wrong version (#1860) (#1861)
62fb618 
In #1831 we added the change notes to v1.14.0's notes but this fix did not make
it into the v1.14.0 release. In this patch we're moving the notes into the
future v1.15.0 release's notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees

@codebykat codebykat

Labels
None yet
Projects
No open projects
Stable
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebykat @dmsnell