State Refactor: Move note info into Redux

[codebykat]

Fix

This moves the showNoteInfo boolean and associated toggles into Redux state.

Test

1. Click the note details pane and make sure note details is shown
2. Click the X or outside the pane and make sure it toggles closed

Review

Code review: Please check to make sure I did this right and didn't miss anything! I used #1881 as an example.

I moved showNoteInfo from appState.showNoteInfo to state.ui.showNoteInfo, added new actions and a new reducer, and removed the legacy action.

In the reducer I am definitely eyeing VisiblePanes as potentially a more logical place to put this (along with the Navigation, see below) but this PR seemed complicated enough already so I decided to stick with a statewide boolean for now.

Another thing of note is that the former incarnation of this action also sets showNavigation and editingTags to false when the notes panel is shown. I was unable to figure out what edge cases that was meant to handle, so I'm not sure if it is still necessary, and it seems it will be somewhat complicated without growing the PR to also move those two state variables into Redux. (See my line comments on the diff below.)

[codebykat]

Again, I believe we don't need to handle these cases explicitly, but I hope someone can verify that

[dmsnell]

we can verify it!

[dmsnell]

in testing I can see that it's more of a choice to change the behavior or keep it. if we take this out then the note info stays open when we flip the navigation panel.

[codebykat]

I haven't been able to make that happen, what are the steps? If I open note info, there's no way to open the navigation panel (any click is an "outside click" that closes the note info).

[codebykat]

From Slack: "Use the keyboard shortcut Cmd + t and flip the tag drawer/nav panel open and closed"

I tried this and it does seem to close the info panel, so I'm gonna say.. it's fine.

[dmsnell]

sorry. I should have clarified that - obviously this code closes the note info panel when toggling the navigation panel. however, when I removed the case 'App.toggleNavigation' as it seemed like you were suggesting would be possible, then the note info would stay open on navigation.

That is, this is an answer to the question "can we skip handling these cases explicitly" and that answer is "if we want and decide to."

[dmsnell]

Lookin' good @codebykat - I hope you found the examples and documentation helpful. Left a few notes which I think might make your job easier. If not, don't hesitate to reach out and challenge or ask.

[belcherj]

Looks great, I didn't see anything outside of what Dennis came up with!

[belcherj]

Does look like you have a linting error. https://circleci.com/gh/Automattic/simplenote-electron/9628?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

[codebykat]

Cool, that all makes sense! Fixed some nits and up for review again. Thanks @dmsnell :)

One thing is I couldn't figure out how to remove the dispatch argument from MapDispatchToProps in note-info (here):

It works in note-toolbar (here) and I'm not sure what the difference is:

There is some other stuff that needs to be moved to Redux in note-detail, and I don't think I understand the onOutsideClick situation, so maybe that's why?

[codebykat]

Rebased and tested both this and the edit mode toggle (which was entangled).

[dmsnell]

Seems like a good merge and I don't think we need to worry about asking whether we should handle the App.toggleNavigation action or not. As-is the code matches the existing behavior so that's an easier call to make when refactoring than whether we should change behavior.