Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: Checkbox #2023

Merged
merged 3 commits into from
May 12, 2020
Merged

Types: Checkbox #2023

merged 3 commits into from
May 12, 2020

Conversation

belcherj
Copy link
Contributor

Fix

Adds types to the Checkbox component

Test

Just types no functional change

Release

Added types to the Checkbox component

@belcherj belcherj requested a review from a team April 21, 2020 05:10
@belcherj belcherj self-assigned this Apr 21, 2020
@belcherj belcherj requested a review from a team April 27, 2020 17:41
@dmsnell dmsnell added this to the 1.17 milestone Apr 28, 2020
dmsnell
dmsnell approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: Resistance is the voltage across a component divided by the current moving through it 😉

Looks good

@belcherj belcherj merged commit 526025d into develop May 12, 2020
@belcherj belcherj deleted the types/checkbox branch May 12, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@belcherj @dmsnell