Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 32 bit version for Windows Store #2067

Merged
merged 1 commit into from
May 12, 2020
Merged

Add 32 bit version for Windows Store #2067

merged 1 commit into from
May 12, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented May 7, 2020

Fix

This will build both a 32 and 64-bit version for the app store. I don't this is entirely needed but since we are moving to 64-bit we should have a fallback for 32 bit.

Test

  1. Create a tag, push it
  2. Observe builds for win-store being created.

@belcherj belcherj self-assigned this May 7, 2020
@belcherj belcherj added this to the 1.17 milestone May 7, 2020
@belcherj belcherj requested a review from codebykat May 7, 2020 11:48
@dmsnell
Copy link
Contributor

dmsnell commented May 7, 2020 •
edited

Related #1986 #2042

@nsakaimbo nsakaimbo self-requested a review May 11, 2020 15:21
nsakaimbo
nsakaimbo approved these changes May 11, 2020
View reviewed changes
Copy link

@nsakaimbo nsakaimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward - LGTM. 👍

@belcherj belcherj merged commit 6a0fc6a into develop May 12, 2020
@belcherj belcherj deleted the add/32bit-unsigned-win-store-appx branch May 12, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsakaimbo nsakaimbo nsakaimbo approved these changes

@codebykat codebykat Awaiting requested review from codebykat

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@belcherj @dmsnell @nsakaimbo