Enable system theme for Electron builds #2135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not work in Windows. I think we will need to do some more work on Windows and Linux. |
belcherj
suggested changes
Jun 9, 2020
|
I need this one for mac :) If there is a problem for other platforms, can you split this pr to just support macos? |
|
Superseded by #2882 |
sandymcfadden
added a commit
that referenced
this pull request
May 1, 2021
Picked up from PR #2135 Currently in our Electron builds we don't offer a system theme that responds to the OSs color preference but is available in the web app. This enables it for both Windows and Mac builds. There appears to be a bug in Electron or Chromium on Linux that the app doesn't respond properly to changing the color preferences so it still won't work there. Possibly this will get resolved in Electron 13 due to come out May 25, 2021. It also updates so that the system menu for Windows updates to be the choice of theme in Simplenote itself. So if you specifically choose Light the menu will be light, same for dark, overriding the system color preference. This semi addresses issues #2134 and #1799 as they will both be resolved for Mac and Windows, but still not working on the Linux builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
When we added System theme (follow OS light/dark setting), the version of Electron didn't support it. As of Electron 7.0.0, it seems that it does:
https://www.electronjs.org/docs/tutorial/mojave-dark-mode-guide
This PR enables the System theme setting in both the menu bar and Settings dialog.
Will fix #2134
Test
Review
It looks to me like we're not following the docs here and accessing this property via Electron's
nativeThemeAPI:https://www.electronjs.org/docs/api/native-theme
However, what we're doing appears to work fine, at least on OSX. Possibly @belcherj knows more.
Release
Not updated: Add System theme for Electron builds