Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: build zip and dmg for mac target #2160

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Jun 18, 2020

Fix

Potential fix for auto-updating not working on the mac, see: electron-userland/electron-builder#2199

Test

TBD

Release

TBD

@belcherj
Copy link
Contributor

OSX auto-update will be broken till this gets fixed: electron-userland/electron-builder#4299

@belcherj
Copy link
Contributor

Error: Error: ZIP file not provided: [
{
"url": "https://github.com/Automattic/simplenote-electron/releases/download/v1.18.0/Simplenote-macOS-1.18.0.dmg",
"info": {
"url": "Simplenote-macOS-1.18.0.dmg",
"sha512": "CbGVuTJgNE1XjCNMu21hDHMIkfakcQ7apujhXL5iEtAD8R1+HpcXtz1z+p8Dfd0RmZTijir96LNGsSAlO1mn3A==",
"size": 86451503
}
}
]
at newError (/Applications/Simplenote.app/Contents/Resources/app.asar/node_modules/builder-util-runtime/out/index.js:212:17)
at MacUpdater.doDownloadUpdate (/Applications/Simplenote.app/Contents/Resources/app.asar/node_modules/electron-updater/out/MacUpdater.js:83:48)
at MacUpdater.downloadUpdate (/Applications/Simplenote.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:567:19)
at MacUpdater.doCheckForUpdates (/Applications/Simplenote.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:527:49)
at processTicksAndRejections (internal/process/task_queues.js:85:5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants