Fix updater dialog to properly resolve #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping this to 2.2.0 because the code freeze for 2.1.0 is due today. This seems like a good bug to fix sooner rather than later, though. I'd be happy to ship a new beta for 2.1.0 if you want to get this into it once ready. |
codebykat
approved these changes
Nov 3, 2020
belcherj
added a commit
that referenced
this pull request
Nov 3, 2020
Fixes the updater. The dialog actions were broken because of a deprecated API that was failing silently. This uses the new async flow to ensure that updates work as expected.
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Fixes the updater. The dialog actions were broken because of a deprecated API that was failing silently.
This uses the new async flow to ensure that updates work as expected.
Test
Release
Fixed the Windows updater