Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search bar: Make it into its own component in order to fix layout bugs #2545

Merged
merged 8 commits into from Jan 6, 2021
Merged

Search bar: Make it into its own component in order to fix layout bugs #2545

merged 8 commits into from Jan 6, 2021

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Jan 5, 2021 •
edited

Fix

Fixes #2544 and the issue where the tag bar is overlapped.

Test

  1. Do some searches with matches in long notes
  2. Scroll to the bottom of the note and verify that the tags and last lines of the note are still visible
  3. Switch notes, change the search, verify that the selected result properly resets to the first.

Screenshots

Screen Shot 2021-01-04 at 11 29 23 PM

Release

Fixed layout bugs causing the search results bar to overlap note contents and tag input field

@codebykat codebykat changed the title [WIP] Search bar: Make it into its own component in order to fix layout bugs Search bar: Make it into its own component in order to fix layout bugs Jan 5, 2021
@codebykat codebykat requested a review from a team January 5, 2021 07:33
@codebykat codebykat self-assigned this Jan 5, 2021
@codebykat codebykat added this to the 2.5.0 milestone Jan 5, 2021
@codebykat codebykat marked this pull request as ready for review January 5, 2021 07:34
@codebykat codebykat mentioned this pull request Jan 5, 2021
Closed
dmsnell
dmsnell reviewed Jan 6, 2021
View reviewed changes
lib/note-content-editor.tsx Outdated Show resolved Hide resolved
dmsnell
dmsnell approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a note about expanding the comment where we're resetting the selection as I think a little more could help us in the future but this looks fine to me for merging.

@codebykat codebykat merged commit bcbbf77 into develop Jan 6, 2021
@codebykat codebykat deleted the fix/search-results-bar-styles branch January 6, 2021 00:26
@pachlava
Copy link
Contributor

Verified on Windows with Electron 2.5.0-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees

@codebykat codebykat

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

'N Results' bar blocks last line of long notes
3 participants
@codebykat @pachlava @dmsnell