-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simperium: Sync'ing Account Entities #1091
Simperium: Sync'ing Account Entities #1091
Conversation
Generated by 🚫 dangerJS |
You can trigger an installable build for these changes by visiting CircleCI here. |
This reverts commit f493053.
I was running some tests and encountered an issue that remote changes are not applied to a local json storage.
If I restart the app and wait for a bucket to finish indexing, the payload will contain correct information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing things together, it started to get some shape!
Sending you a few comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I see that tests are failing on circleCI, but if I run it locally, it works.
Details
Depends on Simperium PR 606
Ref #1086
cc @eshurakov WDYT? (Feedback definitely more than welcomed!!)
Test: Unverified Account
Email Verification
is never printed in your consoleTest: Verified Account
Email Verification
does get printed in your consoleRelease
These changes do not require release notes.