Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling JSONStorage Support #606

Merged
merged 20 commits into from Jan 19, 2021
Merged

Enabling JSONStorage Support #606

merged 20 commits into from Jan 19, 2021

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jan 13, 2021

Description:

In this PR we're enabling JSON Storage support, and fixing few bugs along the way.
At this stage, our JSON Storage layer doesn't have change tracking support. We'll revisit this in a future iteration.

Details:

  • Implements SPThreadsafeMutableDictionary
  • Updates SPObject so that it relies on the new Threadsafe Mutable Dictionary component
  • Dynamic Buckets no longer persist the lastSeenChange string
  • SPDiffable: Replaced methods in favor of properties
  • SPJSONStorage: Dropped Swizzling

Testing:

@jleandroperez jleandroperez marked this pull request as ready for review January 19, 2021 12:18
Copy link

@eshurakov eshurakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

Comment on lines -49 to 45
[NSMutableDictionary sp_swizzleMethod:@selector(setObject:forKey:) withMethod:@selector(simperiumSetObject:forKey:) error:&error];
[NSMutableDictionary sp_swizzleMethod:@selector(setValue:forKey:) withMethod:@selector(simperiumSetValue:forKey:) error:&error];
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jleandroperez
Copy link
Contributor Author

Thank you Evgenyyy!!

@jleandroperez jleandroperez merged commit 4f7e55a into develop Jan 19, 2021
@jleandroperez jleandroperez deleted the issue/ephemeral-storage branch January 19, 2021 14:52
@jleandroperez jleandroperez mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants