Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Color Tweaks #249

Merged
merged 3 commits into from
Nov 20, 2018
Merged

Theme Color Tweaks #249

merged 3 commits into from
Nov 20, 2018

Conversation

roundhill
Copy link
Contributor

This PR updates the theme colors to match the new coloring that we used in the macOS app for the Mojave dark theme. The main change is a darker background color for the dark theme, with a few small tweaks to the text and divider colors to match the new coloring.

The light theme also now has slightly lighter divider colors.

Before:
simulator screen shot - iphone 7 - 2018-11-19 at 14 21 25

After:
simulator screen shot - iphone 7 - 2018-11-19 at 14 21 57

cc @drw158 for any thoughts.

@davewhitley
Copy link

Looks great!

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!!!

:shipit:

@roundhill roundhill merged commit 9a9d3a7 into develop Nov 20, 2018
@roundhill roundhill deleted the update/theme-colors branch November 20, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants