-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastlane match
: Migrate Code Signing from Google Cloud to S3
#1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencertransier
added
the
tooling
Related to anything that supports the building & maintaining of the project.
label
May 7, 2024
mokagio
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally by running the new code signing lane.
I also added a test lane to build the app for App Store. It succeeded.
AliSoftware
reviewed
May 7, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(I was just going to update the profiles that had expired, but decided to update these lanes while I was at it)
This PR:
2.219.0
to2.220.0
env
file.configure
- We don't need the Google or Apple API auth files because this PR switches to using S3 and theapp_store_connect_api_key
Fastlane action. By using theapp_store_connect_api_key
action, it'll make rotating the ASC key much easier because it's just pulling from the shared file in Mobile Secrets.Test
~/.simplenotemac-env.default
env file, add values forMATCH_S3_ACCESS_KEY
,MATCH_S3_SECRET_ACCESS_KEY
, andMATCH_PASSWORD
from Mobile Secretsbundle exec fastlane app_store_code_signing
bundle exec fastlane app_store_code_signing readonly:false
Review
Release
These changes do not require release notes.