Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane match: Migrate Code Signing from Google Cloud to S3 #1150

Merged
merged 14 commits into from
May 8, 2024

Conversation

spencertransier
Copy link
Contributor

@spencertransier spencertransier commented May 7, 2024

Summary

(I was just going to update the profiles that had expired, but decided to update these lanes while I was at it)

This PR:

  • Migrates the code signing certificates and provisioning storage from Google Cloud to S3
  • Updates Fastlane from 2.219.0 to 2.220.0
  • Updates the needed values in the example user env file
  • Removes unneeded files from .configure - We don't need the Google or Apple API auth files because this PR switches to using S3 and the app_store_connect_api_key Fastlane action. By using the app_store_connect_api_key action, it'll make rotating the ASC key much easier because it's just pulling from the shared file in Mobile Secrets.

Test

  1. In your local ~/.simplenotemac-env.default env file, add values for MATCH_S3_ACCESS_KEY, MATCH_S3_SECRET_ACCESS_KEY, and MATCH_PASSWORD from Mobile Secrets
  2. Run bundle exec fastlane app_store_code_signing
  3. Verify that it completes successfully
  4. Run bundle exec fastlane app_store_code_signing readonly:false
  5. Verify that it completes successfully (everything is up to date, so no changes will be made)

Review

Release

These changes do not require release notes.

@spencertransier spencertransier added the tooling Related to anything that supports the building & maintaining of the project. label May 7, 2024
@spencertransier spencertransier added this to the 2.21 milestone May 7, 2024
@spencertransier spencertransier requested a review from a team May 7, 2024 00:52
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally by running the new code signing lane.

I also added a test lane to build the app for App Store. It succeeded.

fastlane/Fastfile Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Show resolved Hide resolved
fastlane/env/user.env-example Outdated Show resolved Hide resolved
@spencertransier spencertransier merged commit a00c2e2 into trunk May 8, 2024
8 checks passed
@spencertransier spencertransier deleted the update/codesigning branch May 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants