Use S3 for fastlane match #12692
Merged
Use S3 for fastlane match #12692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
crazytonyli
added
the
category: tooling
mokagio
approved these changes
May 13, 2024
There was a problem hiding this comment.
What do you think of taking the chance to:
- Remove
Matchfile - Use
app_store_connect_api_keylike in Pocket Casts Desktop
Of course, those are "refactors" as they don't change the behavior. Approving to unblock.
| secrets_directory = File.join(Dir.home, '.configure', 'woocommerce-ios', 'secrets') | ||
| google_cloud_keys_file(File.join(secrets_directory, 'google_cloud_keys.json')) | ||
| storage_mode('s3') | ||
| s3_bucket('a8c-fastlane-match') |
There was a problem hiding this comment.
We'll need to add s3_region to address a runtime warning. See Automattic/simplenote-macos#1150 (comment)
Suggested change
| s3_bucket('a8c-fastlane-match') | |
| s3_bucket('a8c-fastlane-match') | |
| s3_region('us-east-2') |
|
@mokagio Thanks for the review. I'll focus on the fastlane match repo migration for now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What says in the title.
You can verify this change by running
bundle exec fastlane ios alpha_code_signing && bundle exec fastlane ios appstore_code_signinglocally.