Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prompt for users to download correct app architecture version #15

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add prompt for users to download correct app architecture version #15

merged 2 commits into from
Apr 23, 2024

Conversation

derekblank
Copy link
Contributor

Proposed Changes

Checks Studio architecture and prompts user to download the appropriate version of the app.

  • Adds app.runningUnderARM64Translation to app globals
  • Adds native system prompt to link user to correct app download
Screenshot 2024-04-23 at 6 54 33 pm

Testing Instructions

  • Use the app with an arm64 translated architecture (or set the value of arm64translation to true in ipc-handlers.ts.
  • Observe the prompt to download the correct version of the app

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@derekblank derekblank added the [Type] Enhancement Improvement upon an existing feature label Apr 23, 2024
@derekblank
Copy link
Contributor Author

@fluiddot These are the same changes approved via https://github.com/Automattic/local-environment/pull/288#pullrequestreview-2014492645, but in this PR the dialog copy was updated to "Mac with Apple Silicon Chip" to match the copy on the Studio Download button.

fluiddot
fluiddot approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@derekblank derekblank merged commit 36239b1 into trunk Apr 23, 2024
5 checks passed
@derekblank derekblank deleted the feat/arm64-prompt branch April 23, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees

@derekblank derekblank

Labels
[Type] Enhancement Improvement upon an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekblank @fluiddot