Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language selector to block toolbar #172

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Add language selector to block toolbar #172

merged 3 commits into from
Feb 12, 2021

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Nov 13, 2020

As the most needed & used setting for this block, bump it up to a more accessible place.

Changes proposed in this Pull Request

  • Add a dropdown to select code language to the block toolbar

Testing instructions

  • Add a SyntaxHighlighter code block to a page
  • Change Code language from the block toolbar
  • Make sure code is highlighted accordingly on the frontend
  • Make sure currently selected language is displayed

Screenshot / Video

image

image

@yscik yscik added this to the v3.6.0 milestone Nov 13, 2020
@yscik yscik changed the base branch from master to change/refactor-block November 13, 2020 15:56
@yscik yscik mentioned this pull request Nov 17, 2020
Merged
Base automatically changed from change/refactor-block to master December 17, 2020 15:56
jom
jom approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor things, but otherwise looks good and works well!

syntaxhighlighter.php Outdated Show resolved Hide resolved
src/code-block/toolbar.language.js Outdated Show resolved Hide resolved
@yscik yscik mentioned this pull request Dec 18, 2020
Open
alexsanford
alexsanford approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well!

@alexsanford alexsanford merged commit 9ee1a8f into master Feb 12, 2021
@alexsanford alexsanford deleted the add/toolbar-language branch February 12, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom approved these changes

@alexsanford alexsanford alexsanford approved these changes

@donnapep donnapep Awaiting requested review from donnapep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yscik @jom @alexsanford