Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadrat: Remove PHP templates #4187

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Quadrat: Remove PHP templates #4187

merged 1 commit into from
Jul 8, 2021

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

The PHP templates in Quadrat are no longer used, so we can remove them and greatly simplify our templates.

To test, check that Quadrat continues to load the same.

@scruffian scruffian requested a review from a team July 8, 2021 11:14
@scruffian scruffian self-assigned this Jul 8, 2021
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm Quadrat still loads the same for me with this change!

Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I love this PR!

@scruffian scruffian merged commit 9faabc6 into trunk Jul 8, 2021
@scruffian scruffian deleted the remove/php-templates branch July 8, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants