Removed paragraph margin gap styles. They no longer seem to be needed. #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can remove the margin-top for :first-child However, it looks like the paragraph margins are still needed, see #4738. We need the gaps between paragraph blocks to be 1em, rather than whatever block gap is. |
|
As it exists now the gap between paragraphs in a group also includes a bottom gap which is not the case by default. If using the same block gap isn't desirable then I think we may still need to tweak the styles to keep it more correct in that scenario. |
|
Yeah good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Editor:
View:
After:
Editor:
View:
Brought to light via #4842