Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6025: Varia: Fix Jetpack map block close icon #6339

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

bobmatyas
Copy link
Contributor

@bobmatyas bobmatyas commented Aug 8, 2022

Changes proposed in this Pull Request:

Added CSS to reduce the size of button and eliminate overlap with headings on Varia and its child themes. Tested on all themes listed in the original issue.

If I didn't commit the changes right, let me know.

Varia

Before

Screenshot on 2022-08-08 at 13-12-23

After

Screenshot on 2022-08-08 at 11-51-07

Hever

Before

Screenshot on 2022-08-08 at 11-54-52

After

Screenshot on 2022-08-08 at 12-32-22

Related issue(s):

Fixes #6025

@bobmatyas bobmatyas requested a review from a team August 8, 2022 17:15
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works well.

Only one small nit; bumping the versions isn't necessary for themes in this repo; The deploy action takes care of that. It won't hurt anything in this instance though.

@madhusudhand madhusudhand merged commit dbc69bb into trunk Aug 9, 2022
@madhusudhand madhusudhand deleted the fix/6025 branch August 9, 2022 06:18
@bobmatyas
Copy link
Contributor Author

Only one small nit; bumping the versions isn't necessary for themes in this repo; The deploy action takes care of that. It won't hurt anything in this instance though.

The version bumping happened automatically when I built the theme and child theme. Not sure if the scripts that handle that should be updated?

@madhusudhand
Copy link
Contributor

@bobmatyas It seems to be an issue with the script. I'll make a fix. Thanks for the inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Varia & Child themes: Map block close button is too large
3 participants